Python: The construct else + if = elif
The function get_type_of_sentence() only distinguishes between question and normal sentences. Let's add support for exclamatory sentences to it:
def get_type_of_sentence(sentence):
last_char = sentence[-1]
if last_char == '?':
sentence_type = 'question'
if last_char == '!':
sentence_type = 'exclamation'
else:
sentence_type = 'normal'
return 'Sentence is ' + sentence_type
print(get_type_of_sentence('Who?')) # => 'Sentence is normal'
print(get_type_of_sentence('No')) # => 'Sentence is normal'
print(get_type_of_sentence('No!')) # => 'Sentence is exclamation'
We have added an exclamation checker for exclamation sentences. Technically this feature works, but it treats question sentences incorrectly. There are also problems with it in terms of semantics:
- The exclamation point is checked in any case, even if there is already a question mark
- The
elsebranch is described for the second condition, but not for the first. Therefore the question sentence becomesnormal'.
To remedy the situation, let's take another possibility of conditional construction:
def get_type_of_sentence(sentence):
last_char = sentence[-1]
if last_char == '?':
sentence_type = 'question'
elif last_char == '!':
sentence_type = 'exclamation'
else:
sentence_type = 'normal'
return 'Sentence is ' + sentence_type
print(get_type_of_sentence('Who?')) # => 'Sentence is question'
print(get_type_of_sentence('No')) # => 'Sentence is normal'
print(get_type_of_sentence('No!')) # => 'Sentence is exclamation'
Now all the conditions are lined up in a single construction. The elif means "if the previous condition is not satisfied, but the current condition is satisfied". This is the scheme:
- If the last letter is
? then'question'` - if the last letter is
!, then'exclamation' - other options are
normal'.
Only one of the code blocks that refers to the whole if construct will be executed.
Instructions
The electronic map of Westeros that Sam implemented shows Stark allies in green circles, enemies in red, and neutral families in gray.
Write a function who_is_this_house_to_starks() for Sam that takes the family name as input and returns one of three values: 'friend', 'enemy', 'neutral'.
Rules of Determination:
- Friends (
'friend'):'Karstark','Tully' - Enemies (
'enemy'):'Lannister','Frey' - Any other families are considered
neutral'.
Examples of calls:
print(who_is_this_house_to_starks('Karstark')) # => 'friend'
print(who_is_this_house_to_starks('Frey')) # => 'enemy'
print(who_is_this_house_to_starks('Joar')) # => 'neutral'
print(who_is_this_house_to_starks('Ivanov')) # => 'neutral'
Definitions
- else + if = elif
- a way of setting several alternative conditions.
The exercise doesn't pass checking. What to do? 😶
If you've reached a deadlock it's time to ask your question in the «Discussions». How ask a question correctly:
- Be sure to attach the test output, without it it's almost impossible to figure out what went wrong, even if you show your code. It's complicated for developers to execute code in their heads, but having a mistake before their eyes most probably will be helpful.
In my environment the code works, but not here 🤨
Tests are designed so that they test the solution in different ways and against different data. Often the solution works with one kind of input data but doesn't work with others. Check the «Tests» tab to figure this out, you can find hints at the error output.
My code is different from the teacher's one 🤔
It's fine. 🙆 One task in programming can be solved in many different ways. If your code passed all tests, it complies with the task conditions.
In some rare cases, the solution may be adjusted to the tests, but this can be seen immediately.
I've read the lessons but nothing is clear 🙄
It's hard to make educational materials that will suit everyone. We do our best but there is always something to improve. If you see a material that is not clear to you, describe the problem in “Discussions”. It will be great if you'll write unclear points in the question form. Usually, we need a few days for corrections.
By the way, you can participate in courses improvement. There is a link below to the lessons course code which you can edit right in your browser.
Your exercise will be checked with these tests:
1import index
2
3
4def test1():
5 assert index.who_is_this_house_to_starks('Tully') == 'friend'
6 assert index.who_is_this_house_to_starks('Karstark') == 'friend'
7 assert index.who_is_this_house_to_starks('Lannister') == 'enemy'
8 assert index.who_is_this_house_to_starks('Martell') == 'neutral'
9 assert index.who_is_this_house_to_starks('undefined') == 'neutral'
10Teacher's solution will be available in:
